CellWorX: fix plate name and dimensions #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtbc
reviewed
Jan 18, 2017
| store.setPlateName(plate.getName(), 0); | ||
|
|
||
| plateName = plate.getName(); | ||
| if (plateName.indexOf(".") > 0) { |
|
Works like expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CellWorX plate naming bug reported by @pwalczysko and @dominikl in ome/openmicroscopy#4992 (comment).
The test dataset is
data_repo/curated/cellworx/pki/SKMEL28_10K_1.HTD. Without this PR,showinf -nopix -omexml SKMEL28_10K_1.HTDshould show OME-XML with aPlateNameset topki(the folder containing the dataset). No other attributes onPlatewill be present apart fromID.Moving or copying the .HTD and *.pnl files to a different containing folder and repeating the test should show that the
PlateNamechanges to match the containing folder name.With this PR, the same
showinftest should indicate that the plate name is alwaysSKMEL28_10K_1, regardless of the containing folder name. TheRowsandColumnsattributes onPlateshould also be set to 8 and 12 respectively.