Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the the original PostgreSQL configuration file #41
base: master
Are you sure you want to change the base?
Use the the original PostgreSQL configuration file #41
Changes from 2 commits
82efa2d
3637a0e
35930b0
0879c9f
9ee77fa
9790b98
743d5f3
dcaa4eb
8151508
5b1c41a
bc2b2ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 25 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check failure on line 25 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)
Check warning on line 30 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check warning on line 30 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)
Check failure on line 57 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check failure on line 57 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)
Check failure on line 61 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check failure on line 61 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly the logic, this is meant to create a one-off copy of the configuration file assuming the latter has not originally been modified (and templated) by Ansible.
.backup
implies to me that a copy of the modified configuration. Would a different suffix e.g..orig
would better convey that this is meant to be the version of the configuration installed by the package manager?Check warning on line 70 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check warning on line 70 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)
Check failure on line 86 in tasks/initialise.yml
GitHub Actions / Test (rockylinux9)
Check failure on line 86 in tasks/initialise.yml
GitHub Actions / Test (ubuntu2204)