Skip to content

Commit

Permalink
Fix bad configure tests that breaks homebrew/clang
Browse files Browse the repository at this point in the history
The clang script that's included with homebrew gets confused with the -c
flag and returns a wrong result for some configure tests. The -c flag is
not needed for this check.

See
dotnet/source-build#1744 (comment)
and
dotnet/source-build#1744 (comment)
for more details.
  • Loading branch information
janvorli authored and omajid committed Sep 25, 2020
1 parent db0d25d commit 33d2119
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreclr/src/pal/src/configure.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ if(NOT CLR_CMAKE_USE_SYSTEM_LIBUNWIND)
list(INSERT CMAKE_REQUIRED_INCLUDES 0 ${CMAKE_CURRENT_SOURCE_DIR}/libunwind/include ${CMAKE_CURRENT_BINARY_DIR}/libunwind/include)
endif()

set(CMAKE_REQUIRED_FLAGS "-c -Werror=implicit-function-declaration")
set(CMAKE_REQUIRED_FLAGS "-Werror=implicit-function-declaration")

check_c_source_compiles("
#include <libunwind.h>
Expand Down

0 comments on commit 33d2119

Please sign in to comment.