[Moves][Fix] Convert username to string #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsapronov
changed the title
omab
force-pushed
the
master
branch
2 times, most recently
from
1078c07 to
de9f179
Compare
|
I've ported this PR into social-core. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I got error in line
https://github.com/omab/python-social-auth/blob/master/social/pipeline/user.py#L45
In this line, we split username value into parts. But if a username is an int value, then we will get an error.
In Moves backend, we store user_id (int value) in a username variable.
https://github.com/omab/python-social-auth/blob/master/social/backends/moves.py#L25