Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #7

Closed
notmedia opened this issue Sep 1, 2024 · 9 comments
Closed

Feedback #7

notmedia opened this issue Sep 1, 2024 · 9 comments

Comments

@notmedia
Copy link

notmedia commented Sep 1, 2024

Hi, thank you for this awesome plugin! It really helps to organise my chords, you made my day :)

I want to share my feedback, these things could be potential improvements.

  1. Fonts in reading and edit views are different. Perhaps this plugin use own font for reading view, would be better if it used font from settings without any differences or have an option to set font for reading view.

Reading view:
image

Edit view:
image

  1. Add ability to write extra text on the same line with chords. Right now sometimes extra text breaks pasring chords in lyrics
image
  1. Sometimes autoscroll button disappears from the right top corner. Try to open any documents without chords and then go back
image
  1. Would be grate if I can revert transpose to the original (first saved or marked as original) if possible.
@olvidalo
Copy link
Owner

olvidalo commented Sep 10, 2024

Thanks for your feedback!

Fonts in reading and edit views are different. Perhaps this plugin use own font for reading view, would be better if it used font from settings without any differences or have an option to set font for reading view.

This has been improved in the latest release, see #6.

Add ability to write extra text on the same line with chords. Right now sometimes extra text breaks pasring chords in lyrics

The chord line detection "algorithm" in this plugin is really dumb: if more than half of the words look like chords, the line is deemed a chord line and only then chords in the line are parsed are highlighted. This prevents words such as "a" and "am" in text lines being highlighted as chords. I am hesitant to implement more sophisticated heuristics to detect mixed text / chord lines because for most cases it works really well as is and it will never be possible to catch all the edge cases.

However I might "borrow" the approach of marking lines explicitly as chord or lyrics lines from the Chord Lyrics plugin, where chord lines can be marked with %c and text lines with %t at the end of the line, overriding automatic detection. So for your mixed line you could write:

Am           G           F        E  (this text breaks highlighting) %c
Lorem ipsum

Forced text lines will mistakenly render some words as chords though, such as in

Am          G           F        E  (i am a forced chords line) %c
Lorem ipsum

Where "am" and "a" would be highlighted. But this would still be better than no chord detection at all for mixed lines. What do you think, would something like this be helpful?

Sometimes autoscroll button disappears from the right top corner. Try to open any documents without chords and then go back

Will look into this.

Would be grate if I can revert transpose to the original (first saved or marked as original) if possible.

While I see the convenience of such a feature I think this is out this plugin's scope I'm afraid. Transposing is just an editing operation, so it can just be undone like other edits. Marking a version as the original would be better handled by dedicated versioning plugins such as the git plugin.

@notmedia
Copy link
Author

Hi, thank you for response!

What do you think, would something like this be helpful?

This would be nice, but need to be an optional thing so I could set %c only on wrong parsed lines with chords without editing the whole lyrics.

Transposing is just an editing operation, so it can just be undone like other edits.

Understood, you are right

@olvidalo
Copy link
Owner

The autoscroll button issue has been fixed in the latest release.

@gautamneeraj
Copy link

This is a great contribution to the Obsidian community! Thank you!!!

Is there an implementation to render Chords from this format?

The [C]sun comes [G]up
It's a [D]new day [Em]dawning

olvidalo added a commit that referenced this issue Sep 30, 2024
@olvidalo
Copy link
Owner

Line markers and inline chords are supported in the latest release.

@gautamneeraj
Copy link

gautamneeraj commented Oct 1, 2024

Line markers and inline chords are supported in the latest release.

Thank you for including [C] as the line markers (e.g. [c] instead of %c)

Two Issues:

  1. When transposing +1, [C] gets transposed as C# without the []. The transposed chord should be inside []
  2. Could you render the line marked Chords a line above the lyrics, right above where it should be
  • Example:
    The [C]sun comes [G]up
    It's a n[D]ew day [Em]dawning

The Chords should be displayed right above the letters where they are placed.
In the example above [C] should be displayed right above the "s" of the "sun" and
[D] should be displayed right above the "e" of the "new"
However, the chords should be displayed without the [].

Thank you for all your hard work!!!! this is amazing.

@olvidalo olvidalo reopened this Oct 1, 2024
@gautamneeraj
Copy link

  1. When transposing +1, [C] gets transposed as C# without the []. The transposed chord should be inside []

Wow!!! you fixed it so quickly. Thank you!

@gautamneeraj
Copy link

gautamneeraj commented Oct 1, 2024

This feature would be immensely valuable to print the Chord Charts.

To render the Chords above the lines of the lyrics, right above where it should be

Example:

The [C]sun comes [G]up
It's a n[D]ew day [Em]dawning

The Chords should be displayed right above the letters where they are placed.

In the example above [C] should be displayed right above the "s" of the "sun" and
[D] should be displayed right above the "e" of the "new"
However, the chords above the lines of the lyrics should be displayed without the [].

To keep in mind, there can me multiple chords in a single word. The word should be displayed using hyphens "-".

Example:

It's a [G]be[Em]au[Am]ti[Dm]full[C] day

It's a be - au - ti - full day

Thank you for all your hard work!!!! this is amazing.

@olvidalo
Copy link
Owner

olvidalo commented Oct 1, 2024

Thanks for reporting the transpose issue. Appreciate your feedback!

The Chords should be displayed right above the letters where they are placed.

I see why this feature could be useful, but for now I want to stick with the behaviour that is expected from code blocks, meaning: everything should be displayed exactly as is, nothing should be hidden or moved somewhere else. So I won't implement such a feature for now, sorry!

I'm going to lock this issue to keep this organized and to not spam the original author with more comment notifications :)
Please feel free to open one or more new single-topic issues if there's anything more.

Repository owner locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants