-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #7
Comments
Thanks for your feedback!
This has been improved in the latest release, see #6.
The chord line detection "algorithm" in this plugin is really dumb: if more than half of the words look like chords, the line is deemed a chord line and only then chords in the line are parsed are highlighted. This prevents words such as "a" and "am" in text lines being highlighted as chords. I am hesitant to implement more sophisticated heuristics to detect mixed text / chord lines because for most cases it works really well as is and it will never be possible to catch all the edge cases. However I might "borrow" the approach of marking lines explicitly as chord or lyrics lines from the Chord Lyrics plugin, where chord lines can be marked with
Forced text lines will mistakenly render some words as chords though, such as in
Where "am" and "a" would be highlighted. But this would still be better than no chord detection at all for mixed lines. What do you think, would something like this be helpful?
Will look into this.
While I see the convenience of such a feature I think this is out this plugin's scope I'm afraid. Transposing is just an editing operation, so it can just be undone like other edits. Marking a version as the original would be better handled by dedicated versioning plugins such as the |
Hi, thank you for response!
This would be nice, but need to be an optional thing so I could set
Understood, you are right |
The autoscroll button issue has been fixed in the latest release. |
This is a great contribution to the Obsidian community! Thank you!!! Is there an implementation to render Chords from this format?
|
Line markers and inline chords are supported in the latest release. |
Thank you for including [C] as the line markers (e.g. [c] instead of %c) Two Issues:
The Chords should be displayed right above the letters where they are placed. Thank you for all your hard work!!!! this is amazing. |
Wow!!! you fixed it so quickly. Thank you! |
This feature would be immensely valuable to print the Chord Charts. To render the Chords above the lines of the lyrics, right above where it should be Example:
The Chords should be displayed right above the letters where they are placed. In the example above [C] should be displayed right above the "s" of the "sun" and To keep in mind, there can me multiple chords in a single word. The word should be displayed using hyphens "-". Example:
It's a be - au - ti - full day Thank you for all your hard work!!!! this is amazing. |
Thanks for reporting the transpose issue. Appreciate your feedback!
I see why this feature could be useful, but for now I want to stick with the behaviour that is expected from code blocks, meaning: everything should be displayed exactly as is, nothing should be hidden or moved somewhere else. So I won't implement such a feature for now, sorry! I'm going to lock this issue to keep this organized and to not spam the original author with more comment notifications :) |
Hi, thank you for this awesome plugin! It really helps to organise my chords, you made my day :)
I want to share my feedback, these things could be potential improvements.
Reading view:
Edit view:
The text was updated successfully, but these errors were encountered: