Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bjeavons/zxcvbn-php with mkopinsky/zxcvbn-php #12

Closed
DevLazio opened this issue Jun 19, 2019 · 2 comments
Closed

Replace bjeavons/zxcvbn-php with mkopinsky/zxcvbn-php #12

DevLazio opened this issue Jun 19, 2019 · 2 comments
Assignees
@olssonm

Comments

@DevLazio
Copy link

As discussed in this thread bjeavons/zxcvbn-php#15 there is a discrepancy between bjeavons/zxcvbn-php and the upstream JS version.
The mkopinsky/zxcvbn-php fork fixes these issues and should probably be used instead of bjeavons/zxcvbn-php.
@olssonm
Copy link
Owner

olssonm commented Jun 19, 2019

Thanks, I've missed that discussion. Will look into it ASAP!

@olssonm olssonm self-assigned this Jun 19, 2019
olssonm added a commit that referenced this issue Jun 20, 2019
@olssonm
Merge pull request #13 from olssonm/dev
2e0534b 
Update for #12
@olssonm
Copy link
Owner

olssonm commented Jun 20, 2019

Thanks for pointing this out, a new version (v4.0) is now released: https://github.com/olssonm/l5-zxcvbn/releases/tag/v4.0

@olssonm olssonm closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olssonm olssonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olssonm @DevLazio