Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on tokening the Ruhr #133

Closed
ollybh opened this issue May 27, 2024 · 0 comments
Closed

Error on tokening the Ruhr #133

ollybh opened this issue May 27, 2024 · 0 comments
Assignees
@ollybh
Labels
18Ardennes bug Something isn't working

Comments

@ollybh
Copy link
Owner

ollybh commented May 27, 2024 •
edited
Loading

Whilst attempting to lay a token for M9 in The Ruhr(B16) I receive an error message

"undefined method 'logo=' for nil"

and the token refuses to go there. Other places may be okay.

https://gist.github.com/ollybh/a34fccf4aa4e1b8d8ea96b874b62e1a7#file-18ardennes-ruhr-logo-error-json
@ollybh ollybh added bug Something isn't working 18Ardennes labels May 27, 2024
@ollybh ollybh self-assigned this May 27, 2024
@ollybh ollybh closed this as completed Jun 27, 2024
ollybh added a commit that referenced this issue Jun 27, 2024
@ollybh
[18Ardennes] Fix error on tokening multi-slot city
dd465ee 
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot #1 when placing a token this worked correctly, but
clicking on slot #2 errored, as the game was then attempting to change
the logo of the token in slot #2, but the token had gone to slot #1.

Fixes #133.
ollybh added a commit that referenced this issue Jun 27, 2024
@ollybh
[18Ardennes] Fix error on tokening multi-slot city
5c744dc 
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot #1 when placing a token this worked correctly, but
clicking on slot #2 errored, as the game was then attempting to change
the logo of the token in slot #2, but the token had gone to slot #1.

Fixes #133.
ollybh added a commit that referenced this issue Jul 9, 2024
@ollybh
[18Ardennes] Fix error on tokening multi-slot city
d4a8f8b 
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot #1 when placing a token this worked correctly, but
clicking on slot #2 errored, as the game was then attempting to change
the logo of the token in slot #2, but the token had gone to slot #1.

Fixes #133.
vandamm pushed a commit to 18xx-ru/18xx that referenced this issue Jul 15, 2024
@ollybh @vandamm
[18Ardennes] Fix error on tokening multi-slot city
af023e6 
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot #1 when placing a token this worked correctly, but
clicking on slot tobymao#2 errored, as the game was then attempting to change
the logo of the token in slot tobymao#2, but the token had gone to slot #1.

Fixes ollybh#133.
PistonPercy pushed a commit to PistonPercy/18xx that referenced this issue Jul 22, 2024
@ollybh @PistonPercy
[18Ardennes] Fix error on tokening multi-slot city
7f43edc 
An error was occurring when attempting to token the brown Ruhr tile
(3-slot city). There was already a token in slot #0. If the player
clicks on slot tobymao#1 when placing a token this worked correctly, but
clicking on slot tobymao#2 errored, as the game was then attempting to change
the logo of the token in slot tobymao#2, but the token had gone to slot tobymao#1.

Fixes ollybh#133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollybh ollybh

Labels
18Ardennes bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ollybh