Examples refactor #329
Merged
Examples refactor #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ParthSareen
commented
Nov 21, 2024
•
ParthSareen
commented
- Reorganized examples and added a readme
- Added some missing examples
ParthSareen
requested review from
mxyng,
mchiang0610 and
jmorganca
and removed request for
mxyng
This was referenced Nov 21, 2024
|
@ParthSareen thanks for putting things together, i will take a look and share some comments. |
Co-authored-by: fujitatomoya <[email protected]>
ParthSareen
force-pushed
the
parth/examples-refactor
branch
from
679ebf9
to
adc0843
Compare
mxyng
reviewed
Nov 21, 2024
|
|
||
|
|
||
| response: ProcessResponse = ps() | ||
| for model in response.models: |
There was a problem hiding this comment.
similar comment as list example
There was a problem hiding this comment.
Not sure what you mean - no details section in this response object
There was a problem hiding this comment.
I meant similar output format to list example
ParthSareen
force-pushed
the
parth/examples-refactor
branch
2 times, most recently
from
a380e22
to
62947c4
Compare
ParthSareen
force-pushed
the
parth/examples-refactor
branch
from
62947c4
to
c64d409
Compare
mxyng
reviewed
Nov 21, 2024
mxyng
reviewed
Nov 21, 2024
ParthSareen
commented
Nov 21, 2024
Co-authored-by: Michael Yang <[email protected]>
Co-authored-by: Michael Yang <[email protected]>
mxyng
reviewed
Nov 21, 2024
mxyng
reviewed
Nov 21, 2024
mxyng
reviewed
Nov 21, 2024
mxyng
reviewed
Nov 21, 2024
ParthSareen
force-pushed
the
parth/examples-refactor
branch
from
52543c2
to
5229a22
Compare
mxyng
reviewed
Nov 21, 2024
mxyng
approved these changes
Nov 21, 2024
Co-authored-by: Michael Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.