Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate embeddings from docs in favor of embed #216

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Deprecate embeddings from docs in favor of embed #216

merged 2 commits into from
Sep 13, 2024

Conversation

royjhan
Copy link
Contributor

@royjhan royjhan commented Jul 17, 2024 •
edited
Loading

jmorganca
jmorganca reviewed Sep 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jmorganca
jmorganca approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment on the README

@pdevine pdevine merged commit 1ec88ed into main Sep 13, 2024
@pdevine pdevine deleted the royh/embed-docs branch September 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxyng mxyng mxyng approved these changes

@jmorganca jmorganca jmorganca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@royjhan @jmorganca @mxyng @pdevine