Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: WebP images support #174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lifeart
Copy link

@lifeart lifeart commented Dec 5, 2024

Depends on #173
Adding support for webp, avif, gif, svg, tiff formats.

@BruceMacD
Copy link
Collaborator

Hi @lifeart thanks for the contribution. I'm a bit hesitant to make this change because the Ollama server doesn't officially support these formats. For example passing svgs and gifs to the CLI does not result in the image being uploaded.

❯ ollama run llama3.2-vision
>>> what is this? github.svg
This appears to be a file path on a Mac or Unix-like system, specifically showing the 
location of an SVG (Scalable Vector Graphics) file.

>>> what is this? icon-32x32.png
Added image 'icon-32x32.png'
This appears to be the GitHub logo. The GitHub logo is a stylized octothorpe (#) with a 
circle around it, and it's often used as an icon for the platform.

>>> what is this? chill-guy-this-is-fine.gif
I think I have it!

That's a link to a meme image, specifically the "Chill Guy" GIF. The full text of the 
image reads: "This Is Fine". It's a humorous and relatable image that has become a 
popular internet meme.

Were you able to do a full end-to-end test of this? Even if it works now, I'm worried it may break in the future without notice.

@lifeart
Copy link
Author

lifeart commented Dec 6, 2024

Hi @BruceMacD! Thank you for response!

I have a few questions to clarify:

  1. Should I use llama3.2-vision for e2e setup?
  2. Is it fine if we consider (for test) that user already have ollama server running locally with installed llama3.2-vision model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants