Georgian unicode characters #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I really like your gem and I'm using it for my current task, which is an organization website.
I live in Georgia (country, not the state), so most articles will have Georgian titles.
So the issue that I have is that your gem replaces all Georgian characters with "", and it means that articles' permalink field will be empty.
And what I did was that I added Georgian language compatibility, so it doesn't replace Georgian unicode characters with "".
I just changed this line in lib/friendly_url.rb:
n.gsub!(/[^\sa-z0-9_-]/, '')
to
n.gsub!(/[^\sa-zა-ჰ0-9_-]/, '')
("ა" and "ჰ" are the first and the last characters of Georgian alphabet).
The reason why I'm making a pull request and not just changing the gem on my local is that I'll need to set up this website on the server and if you pull my changes, it'll make my life easier.
Thanks in advance.