temporarily pin clap and anstyle dependencies
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
changed the title
clap and anstyle dependencies
|
lol, it looks like the tests also depend on |
hawkw
added a commit
that referenced
this pull request
Oct 20, 2023
Depends on #190 Currently, Kubert has the option to use either Rustls or BoringSSL as the TLS implementation. However, the BoringSSL feature is incomplete, as it only configures Kubert's server to use BoringSSL, while the client will still use "whatever `kube-client` is configured to use". This means that you don't *really* get all-BoringSSL. Meanwhile, using BoringSSL on the client-side is quite fraught without upstream support in `kube-client`. Therefore, this branch rips out the `boring-tls` feature and replaces it with an `openssl-tls` feature. Now, we can ensure that the client and server use the same TLS implementation, because `kube-client` already supports OpenSSL. In addition, I've added new tests for the TLS server, and changed the CI client tests to run with both TLS clients. Closes #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit temporarily pins the
clapdependency version to v4.3.24, since v4.4 changed Clap's MSRV to Rust 1.70, which our dev image doesn't have yet. It was also necessary to add an explicit dep onanstyle, a transitive dep viaclap, so that we could pin that crate to v1.0.0, as v1.0.1 ofanstylealso requires Rust 1.70.