Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps … #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2019 15:58
jborjah
approved these changes
Oct 24, 2019
|
Could you please fix the conflicts? I will than take a look at the PR, test it and possibly merge it to remove warnings :) |
|
When may we expect a new version that contains this fix? 😀 |
|
Hi! i am currently working on building an unstable release version so that I can test the package in our production product, I will let you know if the unstable version is ready and will create a release when it is tested. |
|
I just released a ReleaseCandidate, if you can test it with me that would be amazing! I have not seen any errors on the UNSAFE part yet! https://www.npmjs.com/package/react-swipeable-views |
|
🤔 it seems the fix did not make it into release 0.13.9, did it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to suppress warning