Of more/Server side pagination #4
Conversation
THis adds the server side pagiantion to the component. If count of Tablepagiantion is -1, the pagiantion text changes to X of more than Y and the nextPage button is kept enabled.
|
@Domino987 Oops, I'm sorry. I didn't receive any notification! |
|
What do you think of opening this pull request to https://github.com/mui-org/material-ui directly? |
|
On a side note, after more hindsight. I believe it would be great to move ce2babd forward early on. |
|
I was chatting with @gabrielliwerant regarding how we could move forward and collaborate on the component. I start to feel that doing everything under my branch, wouldn't cut it. What if we iterate on the master branch of https://github.com/mui-org/material-ui instead? We could release the changes on npm but not document the component in production until we find it advanced enough? |
|
I am on vacation so sorry for the delay. Yes moving everything to the master branch will probably encourage more people to join too. Since they can try it out if they want to and just push to material -ui directly. When I am back, I will see if the typescript data type casting is sufficient or if it needs some changes. I think it would greatly improve the usage. So I think it would be good. Let me know, after you pushed the Branch to master and I will open prs with the types and the 'more than pagination' branch. |
|
Cool, thanks for the feedback. Enjoy your holidays. |
Move picker sources into lab (#4) Update README.md [DatePicker] Refactor pickers tests to testing-library and mocha (#5) [TimePicker] Migrate tests to testing library (#8) [DateTimePicker] Migrate tests (#9) Fix all pickers linter errors (#10) Fix all circular dependencies (#11) * Fix all circular dependencies * Enable mocha eslint rules for typescript tests [test] The last step to a green CI (#15) Migrate pickers docs (#12) Downgrade to withStyles for pickers sources (#16) Add public api exports for pickers components (#17) Consolidate component namespace and theme augmentation (#18) Describe conformance for pickers sub-components (#19) Autogenerate proptypes for typescript sources (mui#20) Proper build output (mui#21) Clear migration artifacts (mui#23) Eslint rule for lower-case test name convention (mui#24) DateRangePicker (mui#25) yarn deduplicate Remove GridListTile [DateTimePicker] Fix migration unit tests Fix types Fix typescript types migration issues Fix yarn lerna build (mui#33) Fix karma tests use window.Touch for CI karma tests Remove more outdated diff noise (mui#34) Replace not valid formats with valid ISO strings Try to fix CI touch tests Skip tests if Touch events are not supported Fix merge conflicts Actually type-check Fix safari tests Remove lowercase test name rule The casing is up to the test author. We're not the grammar police in tests. Fix lint Format Remove overzealous eslint-disable* Debug failing tests Better debugging Timezones are fun was isoString th efix? Let's find out what's failing and then skip it Branch for safari Skip DateRangePicker in browsers review Matt's review Co-authored-by: Matt <[email protected]> format docs:i18n
This adds the discussed server side pagination to the TablePagination component.
If count is -1, the text changes to "X of more than Y" and the next page button is kept enabled.