Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

New block notify by connecting to daemons as peer rather than block template polling #151

Closed
shwuhk opened this issue Jan 3, 2018 · 9 comments
Closed

New block notify by connecting to daemons as peer rather than block template polling #151

shwuhk opened this issue Jan 3, 2018 · 9 comments
Labels
enhancement help wanted
Milestone
0.15

Comments

@shwuhk
Copy link

shwuhk commented Jan 3, 2018

Mining core discover new block mined via polling, however, this method has delay(polling interval(. Will you consider to connect to daemons as peer and let daemons to notify a new block is mined. The same feature is implemented in https://github.com/zone117x/node-stratum-pool/blob/master/lib/peer.js
Thanks.
@oliverw
Copy link
Owner

oliverw commented Jan 3, 2018

Planned already.

@Kukks
Copy link
Contributor

Kukks commented Jan 4, 2018

Really cool stuff!

oliverw pushed a commit that referenced this issue Jan 15, 2018
Support ZMQ block notify for Bitcoin family. Fixes #151.
c3d79c3
@oliverw
Copy link
Owner

oliverw commented Jan 15, 2018

@shwuhk This is now implemented using ZMQ pub/sub which is a much cleaner solution that's equally fast.

@oliverw oliverw closed this as completed Jan 15, 2018
@Kukks
Copy link
Contributor

Kukks commented Jan 15, 2018

How does this work? Any configuration needed?

@oliverw
Copy link
Owner

oliverw commented Jan 15, 2018

@Kukks Checkout the release notes for Release 0.15 that I'm just preparing.

oliverw pushed a commit that referenced this issue Jan 15, 2018
Dev (#180)
2c62848 
- Support ZMQ block notify for Bitcoin family. Fixes #151.
- Adjust Lyra2v2 Hashrate multiplier. Fixes #168
- Made RPC polling optional
- Updated configuration examples to be closer to real world usage
- Added no RPC polling config example
@oliverw
Copy link
Owner

oliverw commented Jan 15, 2018

Here you go: https://github.com/coinfoundry/miningcore/releases/tag/0.15

@shwuhk
Copy link
Author

shwuhk commented Jan 17, 2018

This is awesome. It is much better than connecting it via peer method.
I would like to propose that it would be much nicer if it support multiple zmq publisher socket just like what we can have multiple daemons.

@oliverw
Copy link
Owner

oliverw commented Jan 17, 2018

@shwuhk I agree could you file a seperate issue for that?

@shwuhk
Copy link
Author

shwuhk commented Jan 18, 2018 •
edited
Loading

Sure. #183

@calvintam236 calvintam236 added this to the 0.15 milestone Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
4 participants
@oliverw @Kukks @calvintam236 @shwuhk