Improve the performance of Index.add. #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loops in Index.add can easily be called hundreds of thousands of times for large documents. Larger documents can perform particularly badly[1] under Chrome. Removing the usage of reduce and filter in favour of inline native for loops can lead to a 20-30% performance increase in Chrome. Firefox also sees a similar but much smaller impovement (~5%). [1]: mkdocs/mkdocs#859 (comment)
|
Would it be useful for me to create a jsperf test for this (as #163 did) or are the included benchmarks good enough? The new benchmark I added isn't ideal since it causes GitHub to hide the diff. I'd be happy to do this any other way if you have any suggestions. Perhaps the test data needs to be moved to a JSON file. |
|
Thanks for taking a look at this, from the tests I did there was a significant performance improvement, which is always great! I think that the new benchmark is fine for now, having the fixture in a separate file might make browsing the tests etc easier but its no show stopper. I've included your change in the latest version, let me know if you have any issues, and thanks again for your help, much appreciated! |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loops in Index.add can easily be called hundreds of thousands of times for
large documents. Larger documents can perform particularly badly1 under
Chrome. Removing the usage of reduce and filter in favour of inline native for
loops can lead to a 20-30% performance increase in Chrome. Firefox also sees a
similar but much smaller impovement (~5%).