Fixed Vector.insert when index of new element is less than first element #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is included in the latest release 0.5.8, thanks for your help! |
|
No problem at all. Thanks for all your hard work making this library in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with
Index.search()returning some results with a score of zero. The problem was that it was building aqueryVectorwith out-of-order elements (e.g. 55/brazil, 52/brabant, 53/bracknell, 54/bratislava), which turned out to be a bug in theVector.insert()method. The first element inserted could never be preceded by any other elements, leading to the strange order seen above.