Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Point in Time API functionality #1433

Closed
Ryan3435 opened this issue Nov 13, 2020 · 1 comment · Fixed by #1480
Closed

Add Point in Time API functionality #1433

Ryan3435 opened this issue Nov 13, 2020 · 1 comment · Fixed by #1480
Labels
Milestone

Comments

@Ryan3435
Copy link

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.

Which version of Elastic are you using?

[X] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)

Please describe the expected behavior

Elasticsearch seems to recommend moving away from the Scroll API for deep pagination and recommends using the search_after parameter combined with a point in time (PIT) for preserving index state as seen here https://www.elastic.co/guide/en/elasticsearch/reference/current/scroll-api.html

The point in time API is a newer feature that doesn't seem to be implemented in this package yet but has been implemented in the Java API elastic/elasticsearch#61062

The rest APIs for opening and closing PITs can be found here:
https://github.com/elastic/elasticsearch-net/blob/7.10/src/ApiGenerator/RestSpecification/XPack/close_point_in_time.json
https://github.com/elastic/elasticsearch-net/blob/7.10/src/ApiGenerator/RestSpecification/XPack/open_point_in_time.json

and the reference for the Point in Time API is here https://www.elastic.co/guide/en/elasticsearch/reference/current/point-in-time-api.html

I would like to get a jump on moving my code over to using this method rather than scrolling if this is the new recommendation. If you are accepting of pull requests I can work on adding this functionality.

Please describe the actual behavior

Doesn't seem to be implemented yet.

Any steps to reproduce the behavior?

N/A

@olivere olivere added this to the 7.x milestone Dec 10, 2020
@olivere olivere modified the milestones: 7.x, 7.0.22 Mar 4, 2021
@olivere olivere modified the milestones: 7.0.22, 7.0.24 Mar 24, 2021
olivere added a commit that referenced this issue Apr 12, 2021
olivere added a commit that referenced this issue Apr 12, 2021
@olivere
Copy link
Owner

olivere commented Apr 12, 2021

Initial support will be added to 7.0.24.

dungnx pushed a commit to dungnx/elastic that referenced this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants