Remove true method for IsEuclideanRing

It was added in commit 0f9c104 and caused IsIntegralRing wrongly return 'true' e.g. for Integers mod 6, as reported in gap-system#3975.
olexandr-konovalov · Apr 22, 2020 · 24b10d2 · 24b10d2
1 parent d811c34
commit 24b10d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/lib/zmodnz.gd b/lib/zmodnz.gd
@@ -127,13 +127,6 @@ InstallTrueMethod( IsFinite,
     IsZmodnZObjNonprimeCollection and IsDuplicateFree );
 
 
-#############################################################################
-##
-#M  IsEuclideanRing( <R> ) . . . . . . . . . . . .  method for full ring Z/nZ
-##
-InstallTrueMethod(IsEuclideanRing, IsZmodnZObjNonprimeCollection and
-    IsWholeFamily and IsRing);
-
 #############################################################################
 ##
 #V  Z_MOD_NZ

diff --git a/tst/testinstall/ring.tst b/tst/testinstall/ring.tst
@@ -16,6 +16,10 @@ false
 gap> IsIntegralRing( SmallRing(4,3) );
 false
 
+# Zero divisors not on the diagonal
+gap> IsIntegralRing( Integers mod 6 );
+false
+
 # Integral rings
 gap> IsIntegralRing( GF(5) );
 true