Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 small changes #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

3 small changes #8

wants to merge 3 commits into from

Conversation

alwynallan
Copy link

  1. Increased COOLDOWN_TIME to 10 sec because I was seeing about 1 degree of self-heat at 2 sec.
  2. Followed Adafruit's for 0.1 degree resolution on DHT11.
  3. Add esp32 to architectures to quash warning. No problems seen.

@alwynallan
Update library.properties
66c32b0 
Brief testing showed no problems with esp32.
@alwynallan
Update dht_nonblocking.cpp
50c3528 
Followed Adafruit's latest code to return 0.1 degree digit for DHT11. Also increased COOLDOWN_TIME to 10 seconds to reduce self-heating error.
@olewolf
Copy link
Owner

olewolf commented Jan 6, 2021

Awesome, @alwynallan. I'll review it when I get the time (shortly, hopefully) and merge it.

@alwynallan
Update dht_nonblocking.cpp
62113cb 
Switched the order of two DHT11 statements for correct 0.1C digit when negative. Pretty sure Adafruit has it wrong too.
@b3nj1
Copy link

b3nj1 commented Feb 4, 2021

@alwynallan , thanks for the fixes. I'm using this PR successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwynallan @olewolf @b3nj1