Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for distutils during build #85

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

Gr3q
Copy link

@Gr3q Gr3q commented Mar 6, 2022

https://www.python.org/dev/peps/pep-0632/

The warning in question:

DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  from distutils import log

This commit does not migrate from distutils just uses the copy in setuptools instead.

https://www.python.org/dev/peps/pep-0632/

This commit does nit migrate from distutils just uses the copy
in setuptools instead.
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 6, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.22 ⭐ 2.22 ⭐ 0.00
Method Length 36.11 ⭐ 36.11 ⭐ 0.00
Working memory 6.25 🙂 6.25 🙂 0.00
Quality 81.01% 81.01% 0.00%
Other metrics Before After Change
Lines 281 281 0
Changed files Quality Before Quality After Quality Change
setup.py 81.01% ⭐ 81.01% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@oleksis oleksis merged commit 2b5b1d9 into oleksis:master Mar 6, 2022
@Gr3q Gr3q deleted the remove-deprecation-warning branch March 8, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants