Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and fallback to "en" to init wx.Locale #77

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

dieterplex
Copy link

In #62, there is no locale "en_US.UTF-8" and causing wx to popup warning.

In oleksis#62, there is no locale "en_US.UTF-8" and causing wx to popup warning.
youtube_dl_gui/app.py Outdated Show resolved Hide resolved
Use  default locale wx.LANGUAGE_ENGLISH
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 19, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.30 ⭐ 2.30 ⭐ 0.00
Method Length 55.17 ⭐ 55.17 ⭐ 0.00
Working memory 5.40 ⭐ 5.40 ⭐ 0.00
Quality 81.67% 81.67% 0.00%
Other metrics Before After Change
Lines 141 141 0
Changed files Quality Before Quality After Quality Change
youtube_dl_gui/app.py 81.67% ⭐ 81.67% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@oleksis oleksis merged commit acde482 into oleksis:master Jan 19, 2022
@dieterplex
Copy link
Author

Without available checking it still show warning for supported lang on a system missing the locale.

@oleksis
Copy link
Owner

oleksis commented Jan 19, 2022

How we can reproduce the issue? Can make one test for cover this case?

Remember we check the locale for use the catalogs for the GUI translations. In the PR you return the default value and verified. Any case you keep using wx.LANGUAGE_ENGLISH

@oleksis
Copy link
Owner

oleksis commented Jan 19, 2022

@dieterplex Thanks for spot the case

I thinks the idea is like this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants