Fix bug subprocess for Windows

oleksis · Aug 3, 2020 · 0715907 · 0715907
1 parent 897b2c8
commit 0715907
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 20 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 
 ### Fixed
 - Imports for Internationalization with gettext
+- Fix bug subprocess for Windows ([WinError 6] Handler no valid)
 
 ### Changed
 - Migration to Python 3.*

diff --git a/README.md b/README.md
@@ -19,14 +19,14 @@ A cross platform front-end GUI of the popular [youtube-dl](https://rg3.github.io
 * [GNU gettext](https://www.gnu.org/software/gettext/)
 
 ## Downloads
-* [Source (.zip)](https://github.com/oleksis/youtube-dl-gui/archive/v1.0.0-alpha.zip)
-* [Source (.tar.gz)](https://github.com/oleksis/youtube-dl-gui/archive/v1.0.0-alpha.tar.gz)
+* [Source (.zip)](https://github.com/oleksis/youtube-dl-gui/archive/v1.0.1-alpha.zip)
+* [Source (.tar.gz)](https://github.com/oleksis/youtube-dl-gui/archive/v1.0.1-alpha.tar.gz)
 
 ## Installation
 
 ### Install From Source
 * Download & extract the source
-* Change directory into *youtube-dl-gui-1.0.0-alpha*
+* Change directory into *youtube-dl-gui-1.0.1-alpha*
 * Create virtual environment 
 ```
 python3 -m venv env

diff --git a/tests/test_ditem.py b/tests/test_ditem.py
@@ -3,7 +3,6 @@
 
 """Contains test cases for the DownloadItem object."""
 
-from __future__ import unicode_literals
 
 import sys
 import os.path

diff --git a/tests/test_dlist.py b/tests/test_dlist.py
@@ -3,7 +3,6 @@
 
 """Contains test cases for the DownloadList object."""
 
-from __future__ import unicode_literals
 
 import sys
 import os.path

diff --git a/tests/test_parsers.py b/tests/test_parsers.py
@@ -3,7 +3,6 @@
 
 """Contains test cases for the parsers module."""
 
-from __future__ import unicode_literals
 
 import sys
 import os.path

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -3,7 +3,6 @@
 
 """Contains test cases for the utils.py module."""
 
-from __future__ import unicode_literals
 
 import sys
 import os.path

diff --git a/tests/test_widgets.py b/tests/test_widgets.py
@@ -3,7 +3,6 @@
 
 """Contains test cases for the widgets.py module."""
 
-from __future__ import unicode_literals
 
 import sys
 import os.path

diff --git a/youtube_dl_gui/downloaders.py b/youtube_dl_gui/downloaders.py
@@ -318,19 +318,13 @@ def _create_process(self, cmd):
             cmd (list): Python list that contains the command to execute.
 
         """
-        info = preexec = None
-
-        # Keep a unicode copy of cmd for the log
-        # ucmd = cmd
+        info = None
 
         if os.name == 'nt':
             # Hide subprocess window
             info = subprocess.STARTUPINFO()
             info.dwFlags |= subprocess.STARTF_USESHOWWINDOW
-        else:
-            # Make subprocess the process group leader
-            # in order to kill the whole process group with os.killpg
-            preexec = os.setsid
+            info.wShowWindow = subprocess.SW_HIDE
 
         # Encode command for subprocess
         # Refer to http://stackoverflow.com/a/9951851/35070
@@ -339,10 +333,11 @@ def _create_process(self, cmd):
 
         try:
             self._proc = subprocess.Popen(cmd,
+                                          stdin=subprocess.PIPE,
                                           stdout=subprocess.PIPE,
-                                          stderr=subprocess.PIPE,
-                                          preexec_fn=preexec,
-                                          startupinfo=info)
+                                          stderr=subprocess.STDOUT,
+                                          startupinfo=info,
+                                          start_new_session=True)
         except (ValueError, OSError, FileNotFoundError) as error:
             self._log('Failed to start process: {}'.format(str(cmd)))
             self._log(str(error))

diff --git a/youtube_dl_gui/version.py b/youtube_dl_gui/version.py
@@ -1,4 +1,4 @@
 # -*- coding: utf-8 -*-
 
 
-__version__ = '1.0.0'
+__version__ = '1.0.1'