Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, migrate code, remember AnnotatedString, remove redundant flowtext/proguard & Manifest files, migrate to version catalog & kotlin dsl #9

Merged
merged 13 commits into from
Jul 17, 2024

Conversation

w2sv
Copy link
Contributor

@w2sv w2sv commented Jun 18, 2024

And I removed targetSdk from textflow, since setting it has no effect on library modules.

@w2sv w2sv changed the title Update dependencies, migrate code, remember AnnotatedString, remove redundant flowtext/proguard & Manifest files Update dependencies, migrate code, remember AnnotatedString, remove redundant flowtext/proguard & Manifest files, migrate to version catalog & kotlin dsl Jun 19, 2024
Copy link
Owner

@oleksandrbalan oleksandrbalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for those PRs 😍

One thing is, that I have to update pipelines to support Java 17, please see a rebase PR in your fork w2sv#1.

When merged pipelines should go green and we can merge it 🎉

@oleksandrbalan
Copy link
Owner

oleksandrbalan commented Jul 17, 2024

please see a rebase PR in your fork w2sv#1.

Nvm, I figured out that I can push things directly to your fork.
I have made a few changes for new ktlint & detekt 👌

@oleksandrbalan oleksandrbalan merged commit fbf5137 into oleksandrbalan:main Jul 17, 2024
2 checks passed
@w2sv
Copy link
Contributor Author

w2sv commented Jul 17, 2024

Awesome, thank you for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants