Implemented a more reliable way for detecting the internal ip. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@oleksandr Please merge this. |
tmm1
reviewed
Nov 14, 2016
|
|
||
| for _, address := range iaddrs { | ||
| // check the address type and if it is not a loopback the display it | ||
| if ipnet, ok := address.(*net.IPNet); ok && !ipnet.IP.IsLoopback() { |
There was a problem hiding this comment.
One issue here is that it includes ipv6 link-local ips. These can be ignored using && !ipnet.IP.IsLinkLocalUnicast()
|
@oleksandr Please merge #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reimplemented the way the internal ip address gets detected. I did this, because the library was on neither of my machines able to detect its internal ip address.
Tested on osx and two different linux-boxes.