Skip to content

Commit

Permalink
Upgrades in Advance of Dependabot (PHPOffice#3757)
Browse files Browse the repository at this point in the history
More convenient to handle it today than tomorrow. Phpstan flags 1 new statement, but it is incorrect - annotate it.
  • Loading branch information
oleibman authored Sep 30, 2023
1 parent d0fae3f commit db35a41
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 53 deletions.
109 changes: 57 additions & 52 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Calculation/Calculation.php
Original file line number Diff line number Diff line change
Expand Up @@ -4409,7 +4409,7 @@ private function internalParseFormula($formula, ?Cell $cell = null): bool|array
[$rangeWS2, $val] = Worksheet::extractSheetTitle($val, true);
if ($rangeWS2 !== '') {
$rangeWS2 .= '!';
} else {
} else { // @phpstan-ignore-line
$rangeWS2 = $rangeWS1;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class AccruedInterest
* 2 Actual/360
* 3 Actual/365
* 4 European 30/360
* @param mixed $calcMethod Unused by PhpSpreadsheet, and apparently by Excel (https://exceljet.net/functions/accrint-function)
*
* @return float|string Result, or a string containing an error
*/
Expand Down

0 comments on commit db35a41

Please sign in to comment.