fix: add options & endpoint validations, more tests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-koval
force-pushed
the
oleg-koval-gh#14
branch
from
65aaed8 to
1ee3385
Compare
oleg-koval
force-pushed
the
oleg-koval-gh#14
branch
from
1ee3385 to
cba804c
Compare
syllerim
approved these changes
Jan 19, 2018
index.js
Outdated
|
|
||
| this.endpoint = options.endpoint; | ||
| this.log = options.log || console; | ||
| this.log = options.log || console; // TODO: add more loggers |
There was a problem hiding this comment.
Maybe better to create an issue with the description of the todo to make it clear.
There was a problem hiding this comment.
@syllerim already there :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14