Reset driver connection even if stopping the driver fails #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that if an error occurs whilst stopping the driver, that the current driver is still discarded and does not impact subsequent tests. We have experienced issues when testing large datasets whereby the page takes a significant amount of time to load, blocking the driver. As a result the connection timeout is encountered, and the Behat Scenario fails. We also restart the browser between every test to ensure that all caches are cleared. We do this in a Behat hook. When we come to restart the connection and start the next test the WebDriver connection is still hung causing another exception to be thrown during the reset and no way to discard the session and start a new one. Generally this happens very rarely, but when it does happen it currently causes the entire testrun to be aborted and a rerun runs the entire testsuite rather than just the test that originally caused the failure.
oleg-andreyev
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that if an error occurs whilst stopping the driver, that the current driver is still discarded and does not impact subsequent tests.
We have experienced issues when testing large datasets whereby the page takes a significant amount of time to load, blocking the driver. As a result the connection timeout is encountered, and the Behat Scenario fails.
We also restart the browser between every test to ensure that all caches are cleared. We do this in a Behat hook.
When we come to restart the connection and start the next test the WebDriver connection is still hung causing another exception to be thrown during the reset and no way to discard the session and start a new one.
Generally this happens very rarely, but when it does happen it currently causes the entire testrun to be aborted and a rerun runs the entire testsuite rather than just the test that originally caused the failure.