Fix wait method to accept milliseconds #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Aug 4, 2023
This bumps direct dependencies to current ones: - phpunit: 9.5.x No updates here, there is the 9.6.x series available but a lot of deprecation warnings have been introduced there without any alternative to use. See: - sebastianbergmann/phpunit#5160 - sebastianbergmann/phpunit#5062 - ... While that will be handy to prepare ourselves to PHPUnit 10 in some months... we cannot force everybody to jump to 9.6.x because that will make a lot of tests to start emitting warnings. So we stay with PHPUnit 9.5.x for the life of this branch. - mink-phpwebdriver: 1.2.1 No updates here, just changed the constraint because we cannot advance to 1.3.x yet, there is a change there causing some app tests to fail. See: - oleg-andreyev/MinkPhpWebDriver#81 So we stay with 1.2.x until that issue is fixed/clarified, only then we'll review the status. - behat: 3.12.x => 3.13.x And also, automatically, a bunch of 2nd and deepest dependencies. Generated with php80 that is the lowest php version supported by this branch and, also, by some of the dependencies, as per documented @ https://moodledev.io/general/development/tools/composer Worth mentioning behat/mink-goutte-driver, that we should move to mink-browserkit-driver, but that's out from this issue scope.
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Aug 4, 2023
This bumps direct dependencies to current ones: - phpunit: 9.5.x No updates here, there is the 9.6.x series available but a lot of deprecation warnings have been introduced there without any alternative to use. See: - sebastianbergmann/phpunit#5160 - sebastianbergmann/phpunit#5062 - ... While that will be handy to prepare ourselves to PHPUnit 10 in some months... we cannot force everybody to jump to 9.6.x because that will make a lot of tests to start emitting warnings. So we stay with PHPUnit 9.5.x for the life of this branch. - mink-phpwebdriver: 1.2.1 No updates here, just changed the constraint because we cannot advance to 1.3.x yet, there is a change there causing some app tests to fail. See: - oleg-andreyev/MinkPhpWebDriver#81 So we stay with 1.2.x until that issue is fixed/clarified, only then we'll review the status. - behat: 3.12.x => 3.13.x And also, automatically, a bunch of 2nd and deepest dependencies. Generated with php80 that is the lowest php version supported by this branch and, also, by some of the dependencies, as per documented @ https://moodledev.io/general/development/tools/composer Worth mentioning behat/mink-goutte-driver, that we should move to mink-browserkit-driver, but that's out from this issue scope.
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Aug 5, 2023
This bumps direct dependencies to current ones: - phpunit: 9.5.x No updates here, there is the 9.6.x series available but a lot of deprecation warnings have been introduced there without any alternative to use. See: - sebastianbergmann/phpunit#5160 - sebastianbergmann/phpunit#5062 - ... While that will be handy to prepare ourselves to PHPUnit 10 in some months... we cannot force everybody to jump to 9.6.x because that will make a lot of tests to start emitting warnings. So we stay with PHPUnit 9.5.x for the life of this branch. - mink-phpwebdriver: 1.2.1 No updates here, just changed the constraint because we cannot advance to 1.3.x yet, there is a change there causing some app tests to fail. See: - oleg-andreyev/MinkPhpWebDriver#81 So we stay with 1.2.x until that issue is fixed/clarified, only then we'll review the status. - behat: 3.12.x => 3.13.x And also, automatically, a bunch of 2nd and deepest dependencies. Generated with php74 that is the lowest php version supported by this branch and, also, by some of the dependencies, as per documented @ https://moodledev.io/general/development/tools/composer Worth mentioning behat/mink-goutte-driver, that we should move to mink-browserkit-driver, but that's out from this issue scope.
NoelDeMartin
added a commit
to NoelDeMartin/moodleapp
that referenced
this pull request
Dec 5, 2023
The behaviour of wait for new versions has changed, so we need to implement it ourselves. See oleg-andreyev/MinkPhpWebDriver#81
NoelDeMartin
added a commit
to NoelDeMartin/moodleapp
that referenced
this pull request
Dec 5, 2023
The behaviour of wait for new versions has changed, so we need to implement it ourselves. See oleg-andreyev/MinkPhpWebDriver#81
NoelDeMartin
added a commit
to moodlehq/moodle-local_moodleappbehat
that referenced
this pull request
Dec 11, 2023
The behaviour of wait for new versions has changed, so we need to implement it ourselves. See oleg-andreyev/MinkPhpWebDriver#81
oleg-andreyev
approved these changes
Jan 23, 2024
|
@NoelDeMartin sorry that you had to wait for such long time. |
jerico-castillo
pushed a commit
to jerico-castillo/my-moodleapp
that referenced
this pull request
Apr 2, 2024
The behaviour of wait for new versions has changed, so we need to implement it ourselves. See oleg-andreyev/MinkPhpWebDriver#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent update #79, the
waitmethod started rounding milliseconds to seconds and I'm not sure that it was intentional (after all, if thewaitmethod is only supposed to take seconds, it should take anint $secondsargument instead).