Do not call strtolower on null (PHP 8.1 warning) (#76)

oleg-andreyev · Nov 21, 2022 · e265917 · e265917
1 parent c64d82e
commit e265917
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/WebDriver.php b/src/WebDriver.php
@@ -575,7 +575,7 @@ public function getValue($xpath)
     {
         $element = $this->findElement($xpath);
         $elementName = strtolower($element->getTagName());
-        $elementType = strtolower($element->getAttribute('type'));
+        $elementType = strtolower($element->getAttribute('type') ?: 'text');
 
         // Getting the value of a checkbox returns its value if selected.
         if ('input' === $elementName && 'checkbox' === $elementType) {
@@ -647,7 +647,7 @@ public function setValue($xpath, $value)
         }
 
         if ('input' === $elementName) {
-            $elementType = strtolower($element->getAttribute('type'));
+            $elementType = strtolower($element->getAttribute('type') ?: 'text');
 
             if (in_array($elementType, array('submit', 'image', 'button', 'reset'))) {
                 throw new DriverException(sprintf('Impossible to set value an element with XPath "%s" as it is not a select, textarea or textbox', $xpath));
@@ -756,7 +756,7 @@ public function selectOption($xpath, $value, $multiple = false)
         $element = $this->findElement($xpath);
         $tagName = strtolower($element->getTagName());
 
-        if ('input' === $tagName && 'radio' === strtolower($element->getAttribute('type'))) {
+        if ('input' === $tagName && 'radio' === strtolower($element->getAttribute('type') ?: '')) {
             $element = new WebDriverRadios($element);
             $element->selectByValue($value);
             return;
@@ -1146,7 +1146,7 @@ private function findElement($xpath)
      */
     private function ensureInputType(WebDriverElement $element, $xpath, $type, $action)
     {
-        if ('input' !== strtolower($element->getTagName()) || $type !== strtolower($element->getAttribute('type'))) {
+        if ('input' !== strtolower($element->getTagName()) || $type !== strtolower($element->getAttribute('type') ?: 'text')) {
             $message = 'Impossible to %s the element with XPath "%s" as it is not a %s input';
 
             throw new DriverException(sprintf($message, $action, $xpath, $type));