Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Fix footer container. #1180 #1189

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Fix footer container. #1180 #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,18 @@
*/
?>

<div class="footer-container">
<footer class="footer">
<?php dynamic_sidebar( 'footer-widgets' ); ?>
</footer>
</div>
<footer class="footer">
<div class="footer-container">
<div class="footer-grid">
<?php dynamic_sidebar( 'footer-widgets' ); ?>
</div>
</div>
</footer>

<?php if ( get_theme_mod( 'wpt_mobile_menu_layout' ) === 'offcanvas' ) : ?>
</div><!-- Close off-canvas content -->
<?php endif; ?>

<?php wp_footer(); ?>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion library/widget-areas.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function foundationpress_sidebar_widgets() {
'id' => 'footer-widgets',
'name' => __( 'Footer widgets', 'foundationpress' ),
'description' => __( 'Drag widgets to this footer container', 'foundationpress' ),
'before_widget' => '<section id="%1$s" class="large-4 columns widget %2$s">',
'before_widget' => '<section id="%1$s" class="widget %2$s">',
'after_widget' => '</section>',
'before_title' => '<h6>',
'after_title' => '</h6>',
Expand Down
5 changes: 2 additions & 3 deletions src/assets/scss/modules/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
.footer-container {
Copy link
Collaborator

@colin-marshall colin-marshall Dec 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPOak do you think we should add a .footer selector before here and just make the background-color transparent or white by default? The background color is the whole reason we were opting for option 2 after all.

margin: 0 auto;
@include xy-grid-container;
border-top: 1px solid $medium-gray;
margin-top: rem-calc(60);
}

.footer {
@include xy-grid-container;
.footer-grid {
@include xy-grid;
padding: rem-calc(30) 0;

Expand Down