Merge branch 'add shellcheck lint' into dev-2.x

.github/workflows/lint.yaml

@@ -0,0 +1,18 @@
+# Quickstart for GitHub Actions
+# https://docs.github.com/en/actions/quickstart
+
+name: Lint
+on: [ push, pull_request, workflow_dispatch ]
+
+jobs:
+
+  test:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    name: Lint
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: recursive
+      - run: test-cases/lint.sh

bin/xpf

@@ -53,4 +53,5 @@ portableReadLink() {
 THIS_SCRIPT="$(portableReadLink "${BASH_SOURCE[0]}")"
 BASE_DIR="$(dirname "$THIS_SCRIPT")"
 
+# shellcheck disable=SC1091
 source "$BASE_DIR/xpl" "$@"

test-cases/lint.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+set -eEuo pipefail
+
+# cd to the root of the project
+cd "$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"/..
+
+find bin lib legacy-bin -type f |
+  grep -Pv '/show-duplicate-java-classes$' |
+  grep -Pv '/\.editorconfig$' |
+  xargs shellcheck --shell=bash