Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add params to estimateGas api #3304

Merged
merged 2 commits into from
May 14, 2024
Merged

add params to estimateGas api #3304

merged 2 commits into from
May 14, 2024

Conversation

ylsGit
Copy link
Contributor

@ylsGit ylsGit commented May 14, 2024

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.46%. Comparing base (580a0d9) to head (fe4b67b).

❗ Current head fe4b67b differs from pull request most recent head 70df0e5. Consider uploading reports for the commit 70df0e5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3304      +/-   ##
==========================================
+ Coverage   36.50%   37.46%   +0.95%     
==========================================
  Files         446      391      -55     
  Lines       46904    40846    -6058     
==========================================
- Hits        17124    15304    -1820     
+ Misses      28507    24443    -4064     
+ Partials     1273     1099     -174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjianmeng xiangjianmeng merged commit 09bd020 into dev May 14, 2024
8 checks passed
@xiangjianmeng xiangjianmeng deleted the yls/estimateGas-add-params branch May 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants