Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maxValidators #3282

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix maxValidators #3282

merged 2 commits into from
Jan 15, 2024

Conversation

ylsGit
Copy link
Contributor

@ylsGit ylsGit commented Jan 15, 2024

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (f1ce92c) 36.53% compared to head (fce3376) 36.51%.
Report is 1 commits behind head on dev.

❗ Current head fce3376 differs from pull request most recent head 183e190. Consider uploading reports for the commit 183e190 to get more accurate results

Files Patch % Lines
app/rpc/namespaces/eth/api.go 0.00% 35 Missing ⚠️
x/staking/keeper/keeper_ibc_adapter.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3282      +/-   ##
==========================================
- Coverage   36.53%   36.51%   -0.03%     
==========================================
  Files         446      446              
  Lines       46869    46904      +35     
==========================================
+ Hits        17124    17126       +2     
- Misses      28472    28506      +34     
+ Partials     1273     1272       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjianmeng xiangjianmeng merged commit 0bd6b2c into dev Jan 15, 2024
8 checks passed
@xiangjianmeng xiangjianmeng deleted the fix-ibc-maxValidators branch January 15, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants