[Feat] It now infers resource name from Serializer #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource name inference worked like below: |Class name|Resource name| | --- | --- | | FooResource | Foo | | FooSerializer | FooSerializer | | FooElse | FooElse | However we noticed that lots of users use the term `Serializer` and the current behavior is not convenient. It now works like below: |Class name|Resource name| | --- | --- | | FooResource | Foo | | FooSerializer | Foo | | FooElse | FooElse | It now deletes `Serializer` suffix as well.
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 99.21% 99.20% -0.01%
==========================================
Files 13 13
Lines 508 504 -4
==========================================
- Hits 504 500 -4
Misses 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This simplifies `_key` and `_collection_key`.
Now that Alba supports "Serializer" suffix it should be mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource name inference worked like below:
However we noticed that lots of users use the term
Serializerand the current behavior is not convenient. It now works like below:It now deletes
Serializersuffix as well.