[Feat] Implement as_json
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`as_json` returns a Hash like `serializable_hash`, but its result is similar to the result of `serialize`. In other words, `as_json` is a Hash version of `serialize`. Since I changed the root key from String to Symbol, there's one breaking change that affects those who use Oj with `object` mode.
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 11 11
Lines 455 455
=======================================
Hits 450 450
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is because there's no "Symbol" in JSON world. For example, `as_json` method in Rails returns a Hash whose keys are all String. https://api.rubyonrails.org/classes/ActiveModel/Serializers/JSON.html#method-i-as_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_jsonreturns a Hash likeserializable_hash, but its result is similar to the result ofserialize. In other words,as_jsonis a Hash version ofserialize.Since I changed the root key from String to Symbol, there's one breaking change that affects those who use Oj with
objectmode.