Remove compile dependency on openapi-generator #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindkrishnakumar-okta
requested changes
Jun 26, 2023
clementdenis
force-pushed
the
remove_openapigenerator_compile_dep
branch
from
d507dce
to
6d8e825
Compare
- Replace usage of commons-lang's StringUtils with TextUtil from Apache HTTP client
clementdenis
force-pushed
the
remove_openapigenerator_compile_dep
branch
from
6d8e825
to
7adba7c
Compare
|
The reason for the change in RetryUtil was the removal of common-lang3's StringUtils as a dependency, as I was trying to find an alternative I tried to improve it a bit. I rolled back that, and just used Apache HTTP client's |
13 tasks
|
Thanks @clementdenis, I'll close this PR in favor of #911. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SDK currently depends on
openapi-generatoras a compile dependency, which is not needed as the generator is only used for generating SDK classes. Also, this is a huge 6MB library, which adds a lot of weight to dependant projects.Category
Signoff