Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enumUnknownDefaultCase in OpenAPI generator #1000

Closed

Conversation

clementdenis
Copy link
Contributor

Description

The recently added enumUnknownDefaultCase was not actually used. It now is:

public enum ChangeEnum {

    CHANGE("CHANGE"),
    
    KEEP_EXISTING("KEEP_EXISTING"),
    
    UNKNOWN_DEFAULT_OPEN_API("unknown_default_open_api");

   ...

}

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@arvindkrishnakumar-okta
Copy link
Contributor

@clementdenis Thanks much for fixing this!

I'll close this in favor of mergeable PR #1002.

@royathan
Copy link

I wonder if this change led to the mis-casing of this method: addemailAddressesItem

@arvindkrishnakumar-okta
Copy link
Contributor

@literallyjustroy Can you please elaborate?

@royathan
Copy link

Yes, sorry for the quick comment - I was in the middle of upgrading from 16.0.0 -> 17.00 and was looking around for a possible cause.

The 'addEmailAddressItem' method in the BouncesRemoveListObj class was renamed to 'addemailAddressItem'. That change in casing felt odd and perhaps unintentional. Could also have been related to the api generator upgrade as well.

Sorry I'm not super familiar with the project layout so wasn't able pinpoint the source of the change.

@arvindkrishnakumar-okta
Copy link
Contributor

@literallyjustroy Thanks for the clarification!

Yes, it appears to be caused by the Open API Generator upgrade and was unintentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants