Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle network errors and don't cancel context in request before reading response #369

Closed
wants to merge 3 commits into from
Closed

Handle network errors and don't cancel context in request before reading response #369

wants to merge 3 commits into from

Commits on Apr 5, 2023

  1. Don't cancel context in request before reading response 

    This changes the doWithRetries to return a cleanup func to be called
once the response is read instead of taking it down prematurely.

This becomes an issue with large requests where there's a packet
boundary between received headers and rest of the body.
    @ttimonen
    ttimonen committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ef04878 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Unit test for request executor 

    In particular, do check that we have the context available when reading
the response.
    @ttimonen
    ttimonen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7776f92 View commit details
    Browse the repository at this point in the history

  2. Return errors when response reading fails 

    Previously we got partial results instead, and we were having this
happening silently. If we were lucky, the json parsing failed though.
    @ttimonen
    ttimonen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1d378b9 View commit details
    Browse the repository at this point in the history