Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

upgrade all deps for compatibility with node 12 #661

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Feb 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Upgrade dependencies

What is the current behavior?

Issue Number: OKTA-272700

What is the new behavior?

No change

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

Copy link
Contributor

@robertjd robertjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit in the changelog, approve everything else


### Breaking Changes

- [#661](https://github.com/okta/okta-oidc-js/pull/661) Requires Node >= 10.13.0. Add support for Node 12.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bullets for the prod dependencies that we are updating

Copy link
Contributor

@swiftone swiftone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with Rob's comment on CHANGELOG

@aarongranick-okta aarongranick-okta merged commit 0f6e67c into master Feb 4, 2020
@aarongranick-okta aarongranick-okta deleted the ag-node12-OKTA-272700 branch February 4, 2020 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants