fix: select authenticator auto selects when methodType differs #1470
+2,184
−1,453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredperreault-okta
force-pushed
the
jp-OKTA-646147
branch
from
c3a6930
to
e32e657
Compare
| // fix for OKTA-612939 (below) seems to have caused a bug when trying to re-select authenticators | ||
| // with multiple methodTypes. If `options.step` is passed, this remediation is explicitly being | ||
| // invoked, therefore do not guard against auto-remediating the selected authenticator (OKTA-646147) | ||
| if (this.options.step) { |
There was a problem hiding this comment.
Suggested change
| if (this.options.step) { | |
| if (this.options.step || this.values.methodType) { |
What do you think about this fix?
Should cover case if user doesn't provide step, eg:
await oktaAuth.idx.authenticate({ username: '...', password: '...' })
await oktaAuth.idx.proceed({ authenticator: 'phone_number', methodType: 'sms' })
await oktaAuth.idx.proceed({ authenticator: 'phone_number', methodType: 'voice' })
denysoblohin-okta
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
The fix with step looks good to me.
What do you think about checking methodType aswell?
https://github.com/okta/okta-auth-js/pull/1470/files#r1394258583
Please add changelog
| '--verbose', | ||
| '--disable-dev-shm-usage' | ||
| ]); | ||
| if (process.env.CHROME_BINARY) { |
There was a problem hiding this comment.
Do we need to specify CHROME_BINARY in testenv locally?
jaredperreault-okta
force-pushed
the
jp-OKTA-646147
branch
from
8f99b5a
to
1693e28
Compare
jaredperreault-okta
force-pushed
the
jp-OKTA-646147
branch
from
1693e28
to
ac49b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.