Add new extension method that accepts a cookie manager. #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One cannot set the
ICookieManager
used by the underlyingOpenIdConnectMiddleware
. Instead of aborting out of the provided extension methods from Okta and referring to the source for partial reimplementation, just expose the ability to set it. Please see this reference from Microsoft.I don't actually care if this gets merged, or if it is done in exactly this manner. I could not tell whether this way was preferable to exposing a new option, so I arbitrarily picked this one. This is just a non-API breaking example that fulfills my request.
If some way to expose the underlying
ICookieManager
is deemed out of scope or whatever, at the very least, some guidance in the documentation enlightening devs to implement their own extension methods or implementing Okta integration manually withOpenIdConnectMiddleware
should be added.I'm also doing this in part because doing a quick google search against the kinds of issues the reference above creates combined with the term "Okta" shows me a bunch of forum discussions where people are creating
Session_Start()
hacks and other things that make me yell "no!"