Upgrade to react-scripts v5 #91
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ | |
| "start": "cross-env react-app-rewired start", | ||
| "build": "react-app-rewired build", | ||
| "test": "react-app-rewired test --watchAll=false", | ||
| "eject": "react-scripts eject", | ||
| "postinstall": "semantic-ui-css-patch" | ||
| }, | ||
| "dependencies": { | ||
| "@okta/okta-auth-js": "^6.0.0", | ||
|
|
@@ -20,12 +21,13 @@ | |
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-router-dom": "^5.3.0", | ||
| "react-scripts": "^5.0.0", | ||
| "semantic-ui-css": "^2.4.1", | ||
| "semantic-ui-react": "^2.1.1", | ||
| "text-encoding": "^0.7.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@semantic-ui-react/css-patch": "^1.0.0", | ||
|
There was a problem hiding this comment. This workaround is from Semantic-Org/Semantic-UI-React#4287 (comment) |
||
| "react-app-rewired": "^2.1.11" | ||
| }, | ||
| "browserslist": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works when you run
npm start, but there's an ugly warning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredperreault-okta Do you have any idea how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the issue is, but the problem is here: https://github.com/okta-samples/okta-react-sample/blob/main/config-overrides.js#L43.
react-scriptscontains a webpack config internally,config-overridesallows us to customize it. It seems like our customization is colliding with something inreact-scripts5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to get the warning to go away. I think I'll just leave it and hope that someone has a solution someday (if it annoys them).
npm startandnpm run buildwork just fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn. It doesn't work for CI:
Treating warnings as errors because process.env.CI = true.https://github.com/okta-samples/okta-react-sample/runs/6080989731?check_suite_focus=true