Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump haml from 3.1.6 to 5.0.0 #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps haml from 3.1.6 to 5.0.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

haml failure to escape single quotes In haml versions prior to version 5.0.0.beta.2, when using user input to perform tasks on the server, characters like < > " ' must be escaped properly. In this case, the ' character was missed. An attacker can manipulate the input to introduce additional attributes, potentially executing code.

Patched versions: >= 5.0.0.beta.2 Unaffected versions: none

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects haml In haml versions prior to version 5.0.0.beta.2, when using user input to perform tasks on the server, characters like < > " ' must be escaped properly. In this case, the ' character was missed. An attacker can manipulate the input to introduce additional attributes, potentially executing code.

Affected versions: < 5.0.0

Changelog

Sourced from haml's changelog.

5.0.0

Released on April 26, 2017 (diff).

Breaking Changes

  • Haml now requires Ruby 2.0.0 or above.

  • Rails 3 is no longer supported, matching the official Maintenance Policy for Ruby on Rails. Use Haml 4 if you want to use Rails 3. (Tee Parham)

  • Remove :ugly option (#894)

  • The haml command's debug option (-d) no longer executes the Haml code, but rather checks the generated Ruby syntax for errors.

  • Drop parser/compiler accessor from Haml::Engine. Modify Haml::Engine#initialize options or Haml::Template.options instead. (Takashi Kokubun)

  • Drop dynamic quotes support and always escape ' for escape_html/escape_attrs instead. Also, escaped results are slightly changed and always unified to the same characters. (Takashi Kokubun)

  • Don't preserve newlines in attributes. (Takashi Kokubun)

  • HTML escape interpolated code in filters. #770 (Matt Wildig)

      :javascript
        #{JSON.generate(foo: "bar")}
      Haml 4 output: {"foo":"bar"}
      Haml 5 output: {&quot;foo&quot;:&quot;bar&quot;}
    

Added

  • Add a tracing option. When enabled, Haml will output a data-trace attribute on each tag showing the path to the source Haml file from which it was generated. Thanks Alex Babkin.
  • Add haml_tag_if to render a block, conditionally wrapped in another element (Matt Wildig)
  • Support Rails 5.1 Erubi template handler.
  • Support Sprockets 3. Thanks Sam Davies and Jeremy Venezia.
  • General performance and memory usage improvements. (Akira Matsuda)
  • Analyze attribute values by Ripper and render static attributes beforehand. (Takashi Kokubun)
  • Optimize attribute rendering about 3x faster. (Takashi Kokubun)
  • Add temple gem as dependency and create Haml::TempleEngine class. Some methods in Haml::Compiler are migrated to Haml::TempleEngine. (Takashi Kokubun)

Fixed

  • Fix for attribute merging. When an attribute method (or literal nested hash) was used in an old style attribute hash and there is also a (non-static) new style hash there is an error. The fix can result in different behavior in some circumstances. See the commit message for detailed info. (Matt Wildig)
  • Make escape_once respect hexadecimal references. (Matt Wildig)
Commits
  • 78e2a09 Version 5.0.0
  • e5d6409 Note about #770 in Haml 5 changes
  • 1bac6f9 Remove JRuby from allow_failures
  • d45c2d4 Add backslash for @ to support JRuby
  • 8f20707 Enable frozen_string_literal pragma if possible
  • a6bb255 Oops, this was not intentional...
  • aa4c397 Fix spec in #867 for pretty mode removal
  • 11af795 Fallback to default value of preserve option
  • bbbeb7e Update CHANGELOG to include #867
  • ed7f24f Merge pull request #867 from redoPop/atful-css
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [haml](https://github.com/haml/haml) from 3.1.6 to 5.0.0. **This update includes security fixes.**
- [Release notes](https://github.com/haml/haml/releases)
- [Changelog](https://github.com/haml/haml/blob/main/CHANGELOG.md)
- [Commits](haml/haml@3.1.6...v5.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants