Add a mechanism to judge if the raised error is worth being alerted to admin #81
Conversation
runner.go
Outdated
| log.Infof("Stop supervising bot critical error due to context cancellation: %s.", botType) | ||
|
|
||
| default: | ||
| if r.alertJudge != nil && r.alertJudge(err) { |
There was a problem hiding this comment.
As described in its document, Bot/Adapter is encouraged to raise any noteworthy error instead of judging if it can handle the error and keep running by itself. It is the runner's task to make such judgment. This alertJudge mechanism is part of such a feature. The document itself mentioned about this with an example of where to place a rate limiter.
As an extension to such usage, this mechanism may be required to make a judgment such as "send alert to administrators and stop Bot when Bot raises FooReconnectFailureErrors three times within ten seconds." The current implementation with a bool return value cannot satisfy such a requirement. The returning value should be capable of acknowledging if the core should send alert and/or stop Bot.
There was a problem hiding this comment.
Changes in b4ae170 lets registered supervisor tell how to react to the failing Bot.
This addresses #73.
Since this feature involves different features and components --
sarah.Alerter,Bot/Adapter.Run()'s error passing function and this new mechanism -- detailed document should be provided.