-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ai sdk #323
fix: ai sdk #323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @okisdev - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
import { createOpenAI } from '@ai-sdk/openai'; | ||
|
||
export const openai = new OpenAI({ | ||
export const openai = createOpenAI({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (code_refinement): Check if createOpenAI
supports all previous functionalities of OpenAI
class.
@@ -20,7 +20,7 @@ export const illustrator = async (uiStream: ReturnType<typeof createStreamableUI | |||
|
|||
uiStream.append(<Related relatedQueries={objectStream.value} />); | |||
|
|||
const openai = new OpenAI({ | |||
const openai = createOpenAI({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (code_refinement): Validate that createOpenAI
integrates seamlessly with UI components like uiStream
.
@@ -26,7 +26,7 @@ export const clarifier = async (uiStream: ReturnType<typeof createStreamableUI>, | |||
|
|||
let clarifierResponse: TClarifier = {}; | |||
|
|||
const openai = new OpenAI({ | |||
const openai = createOpenAI({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (code_refinement): Check consistency of API key and endpoint usage in createOpenAI
across different settings.
No description provided.