Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ai sdk #323

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: ai sdk #323

merged 1 commit into from
Apr 23, 2024

Conversation

okisdev
Copy link
Owner

@okisdev okisdev commented Apr 23, 2024

No description provided.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 10:31am

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @okisdev - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines +1 to +3
import { createOpenAI } from '@ai-sdk/openai';

export const openai = new OpenAI({
export const openai = createOpenAI({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (code_refinement): Check if createOpenAI supports all previous functionalities of OpenAI class.

@@ -20,7 +20,7 @@ export const illustrator = async (uiStream: ReturnType<typeof createStreamableUI

uiStream.append(<Related relatedQueries={objectStream.value} />);

const openai = new OpenAI({
const openai = createOpenAI({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (code_refinement): Validate that createOpenAI integrates seamlessly with UI components like uiStream.

@@ -26,7 +26,7 @@ export const clarifier = async (uiStream: ReturnType<typeof createStreamableUI>,

let clarifierResponse: TClarifier = {};

const openai = new OpenAI({
const openai = createOpenAI({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (code_refinement): Check consistency of API key and endpoint usage in createOpenAI across different settings.

@okisdev okisdev merged commit 6402ef0 into main Apr 23, 2024
3 checks passed
@okisdev okisdev deleted the fix/ai-sdk branch April 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant