fix: search default with tavily #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @okisdev - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -37,7 +37,7 @@ export const SearchSelect = () => { | |||
| </DropdownMenuTrigger> | |||
| <DropdownMenuContent> | |||
| <DropdownMenuRadioGroup | |||
| value={currentSearchEngineSettings?.Tavily ? 'Tavily' : 'Google'} | |||
| value={currentSearchEngine === SearchEngine.Tavily ? SearchEngine.Tavily : undefined} | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider handling the default case explicitly in the ternary operation.
Using 'undefined' as a fallback in the ternary operation might lead to unexpected behavior if 'currentSearchEngine' is neither 'Tavily' nor 'Google'. It might be safer to explicitly handle the default case.
Suggested change
| value={currentSearchEngine === SearchEngine.Tavily ? SearchEngine.Tavily : undefined} | |
| value={currentSearchEngine === SearchEngine.Tavily ? SearchEngine.Tavily : SearchEngine.Google} |
| @@ -37,7 +37,7 @@ export const SearchSelect = () => { | |||
| </DropdownMenuTrigger> | |||
| <DropdownMenuContent> | |||
| <DropdownMenuRadioGroup | |||
| value={currentSearchEngineSettings?.Tavily ? 'Tavily' : 'Google'} | |||
| value={currentSearchEngine === SearchEngine.Tavily ? SearchEngine.Tavily : undefined} | |||
There was a problem hiding this comment.
suggestion (code-quality): Avoid unneeded ternary statements (simplify-ternary)
Suggested change
| value={currentSearchEngine === SearchEngine.Tavily ? SearchEngine.Tavily : undefined} | |
| value={currentSearchEngine === SearchEngine.Tavily || undefined} |
Explanation
It is possible to simplify certain ternary statements into either use of an|| or !.This makes the code easier to read, since there is no conditional logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.