Fix saving errored tables #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romicolman
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Hi @roll! Just to see if what I am seeing is correct. I ingested the same file, went to row 128, edited the content and then clicked Save changes. The ODE changed the content of the cell and removed the content from the rest of the cells that had the same data. Is this correct?
Grabacion.de.pantalla.2024-11-21.a.la.s.9.15.34.a.m.mov
|
Hi @romicolman, can you please share the file. Is it the same? I can't reproduce the problem: Untitled.Video.November.25.2024.1_49.PM.webm |
|
Yes, here is the file: |
|
Still can't reproduce it... I do the same actions and it goes from 89 errors to 88 errors as expected. @guergana can you please try (uploading this file, fixing one of errors and saving it)? |
|
@guergana |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite a fragile solution that might required to be extended in the future for other types of errors. On the other hand, it seems to be the only solution that's possible with current data flow.
This PR also adds a proper loading/error state management for the saving changes action as after the change this action might be really time-consuming for large files.