Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic layers #80

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Adds basic layers #80

merged 5 commits into from
Dec 10, 2020

Conversation

oke-aditya
Copy link
Owner

@oke-aditya oke-aditya commented Dec 7, 2020

A few layers such as

#61

  • Mish
  • Swish already in PyTorch use name Silu
  • Simple MLP

I don't know other possible layers, will search and keep adding.

@oke-aditya oke-aditya self-assigned this Dec 7, 2020
@oke-aditya oke-aditya added the layers New Layer label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #80 (cf37cde) into master (c574986) will decrease coverage by 0.50%.
The diff coverage is 59.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   78.50%   78.00%   -0.51%     
==========================================
  Files          44       49       +5     
  Lines        1540     1582      +42     
==========================================
+ Hits         1209     1234      +25     
- Misses        331      348      +17     
Flag Coverage Δ
unittests 78.00% <59.52%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quickvision/layers/block_mlp.py 38.88% <38.88%> (ø)
quickvision/layers/functional/act_mish.py 66.66% <66.66%> (ø)
quickvision/layers/act_mish.py 72.72% <72.72%> (ø)
quickvision/layers/__init__.py 100.00% <100.00%> (ø)
quickvision/layers/functional/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c574986...ed4527f. Read the comment docs.

@oke-aditya
Copy link
Owner Author

I will merge this and start adding tests for layers + losses so that we can build these APIs

@oke-aditya oke-aditya merged commit 4a03d9c into oke-aditya:master Dec 10, 2020
@oke-aditya oke-aditya deleted the add_lay branch December 10, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layers New Layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant