Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov #70

Merged
merged 7 commits into from
Mar 4, 2021
Merged

Use codecov #70

merged 7 commits into from
Mar 4, 2021

Conversation

okazy
Copy link
Owner

@okazy okazy commented Mar 2, 2021

概要(Overview・Refs Issue)

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@okazy okazy changed the base branch from 4.0 to use-codecov-test March 4, 2021 08:54
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (use-codecov-test@76e63a7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             use-codecov-test      #70   +/-   ##
===================================================
  Coverage                    ?   76.17%           
  Complexity                  ?     6105           
===================================================
  Files                       ?      437           
  Lines                       ?    20697           
  Branches                    ?        0           
===================================================
  Hits                        ?    15766           
  Misses                      ?     4931           
  Partials                    ?        0           
Flag Coverage Δ Complexity Δ
tests 76.17% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e63a7...4a5f4b6. Read the comment docs.

@okazy
Copy link
Owner Author

okazy commented Mar 4, 2021

爆速レポート

image

@okazy okazy merged commit 5def3d2 into use-codecov-test Mar 4, 2021
@okazy okazy deleted the use-codecov branch March 4, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants